Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url to feed source summary #566

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add url to feed source summary #566

merged 1 commit into from
Oct 6, 2023
+13 −6

Conversation

br648
Copy link
Contributor

@br648 br648 commented Oct 3, 2023

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Add the feed source url param to the feed source summary.

philip-cline
philip-cline approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for me, thanks for the quick fix!

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please advise how the url field will be populated.

src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java Show resolved Hide resolved
@br648 br648 merged commit b22b422 into dev Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@br648 @binh-dam-ibigroup @philip-cline